search

coq-community / math-classes

A library of abstract interfaces for mathematical structures in Coq [maintainer=@spitters,@Lysxia]
https://math-classes.github.io
MIT License
161 stars 43 forks source link

Please create a tag for Coq 8.17 in Coq Platform 2023.03 #115

Closed MSoegtropIMC closed 1 year ago

MSoegtropIMC commented 1 year ago

The Coq team released Coq 8.17+rc1 on December 29th, 2022 and plans to release Coq 8.17.0 around March 7th, 2023. The corresponding Coq Platform release 2023.03 should be released before April 14th, 2023. It can be delayed in case of difficulties until June 30, 2023, but this should be an exception.

This issue is to inform you that to our (possibly a few days old) best knowledge the latest released version of your project (8.15.0) does not work with Coq 8.17+rc1. We tried to remove version restrictions in opam files and possibly make or configure files, but this did not suffice.

Please note that in Coq Platform CI (unlike Coq CI) we test only released / tagged versions. Coq CI is currently testing commit 754ddc768299afdf6274d03d713907d4d0282361 on repository https://github.com/coq-community/math-classes - which likely means that this commit does work in Coq CI.

Could you please create a tag and opam package, or communicate us any existing tag that works with Coq branch v8.17, preferably before March 21st, 2023? In case we might have to delay the Coq Platform release cause of issues with your project, we would prefer to be informed about the situation as early as possible.

In case the tag and opam package are available before March 21st, 2023, it will be included in an early Coq Platform beta release of the for Coq 8.17+rc1.

The working branch of Coq Platform, can be found here main. It contains package pick ~8.17~2023.03+preview1 which already supports Coq version 8.17+rc1 and contains already working (possibly patched / commit pinned) Coq Platform packages.

Please don't close this issue, even after creating the new tag and/or opam package. We will close the issue after updating Coq Platform. This is a measure of 'double book keeping' in order to avoid that we ship the wrong version.

In any case, Coq Platform won't be released before this issue is closed!

Thanks!

P.S.: this issue has been created automatically based on CI status.

CC: https://github.com/coq/platform/issues/335

spitters commented 1 year ago

I expect it to work again, since this PR was merged. https://github.com/coq-community/math-classes/pull/114

MSoegtropIMC commented 1 year ago

Yes - as stated in the message Coq CI seems to work. Coq Platform CI tests only releases / tags, though, and there is no tag which works. So what I would need is a tag.

Zimmi48 commented 1 year ago

@spitters FWIW, the PR you cite is irrelevant (it is for compatibility with Coq 8.18). Anyway, I can propose a PR to test the master branch with Coq 8.17 and create a release.

spitters commented 1 year ago

Thanks!

On Sat, Mar 4, 2023, 22:07 Théo Zimmermann @.***> wrote:

@spitters https://github.com/spitters FWIW, the PR you cite is irrelevant (it is for compatibility with Coq 8.18). Anyway, I can propose a PR to test the master branch with Coq 8.17 and create a release.

— Reply to this email directly, view it on GitHub https://github.com/coq-community/math-classes/issues/115#issuecomment-1454875872, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABTNTWQPTEGOKORHRQU2P3W2OVHXANCNFSM6AAAAAAVK5KLBI . You are receiving this because you were mentioned.Message ID: @.***>

Zimmi48 commented 1 year ago

@MSoegtropIMC Tag created: https://github.com/coq-community/math-classes/releases/tag/8.17.0 I would appreciate if you can handle the opam packaging.

MSoegtropIMC commented 1 year ago

Thanks! I updated the 2023.03 / 8.17 preview pick in my preparation branch to version 8.17.0 and close this issue.

The opam PR is here: https://github.com/coq/opam-coq-archive/pull/2506