search

coq-community / templates

Templates for configuration files and scripts useful for maintaining Coq projects [maintainers=@palmskog,@Zimmi48]
The Unlicense
13 stars 8 forks source link

Account for schedule trigger in new Nix workflow. #104

Closed Zimmi48 closed 3 years ago

Zimmi48 commented 3 years ago

This should normally fix #103 but needs to be tested first.

palmskog commented 3 years ago

The changes are essentially Nix gobbledygook to me. But I can try it out in Huffman with a cronjob (but will take a while).

Zimmi48 commented 3 years ago

There's no Nix-related code in the change, that's only bash and GitHub Actions magic. Anyway, I've tested it on reglang. It works fine for the pull_request, pull_request_target and push events and I expect it will also work fine for the schedule event, but we might want to wait until tomorrow to confirm this.

Zimmi48 commented 3 years ago

It works fine in reglang.

palmskog commented 3 years ago

Can confirm it works in Huffman as well. However, the Nix master builds are for some reason building Coq from scratch (e.g., https://github.com/coq-community/huffman/actions/runs/1212001932)

Zimmi48 commented 3 years ago

The PR fixing the deployment to Cachix from Coq's CI still hasn't been merged. So if your CI is the first coq-community CI to build a particular commit of Coq, it's not surprising that it rebuilds it from scratch. Unfortunately, the Huffman and Reglang schedule pipelines are triggered at the same time, so they cannot take advantage of one of them having built and deployed Coq to Cachix.

palmskog commented 3 years ago

I see, which Coq (or Nix) PR is it? Would be good to know so I know where to look instead of asking...

Zimmi48 commented 3 years ago

That's https://github.com/coq/coq/pull/14723.