search

coq-community / templates

Templates for configuration files and scripts useful for maintaining Coq projects [maintainers=@palmskog,@Zimmi48]
The Unlicense
13 stars 8 forks source link

[Nix Action] Always test a specific commit and not a ref. #107

Closed Zimmi48 closed 3 years ago

Zimmi48 commented 3 years ago

This is a port of the change done in coq-community/coq-nix-toolbox#68 to avoid problems such as not testing the expected commit when re-triggering a workflow on a branch that has received new commits.

We have discovered this issue while investigating https://github.com/coq-community/hydra-battles/issues/100.

@palmskog You have the best overview of the projects that currently use this Nix CI template I think. This fix is not critical in the sense that the only issue is that retrying an old workflow will not provide reliable information.

I will open a PR to update the workflow on one project, just to make sure that I haven't made any mistake while updating the template.

palmskog commented 3 years ago

@Zimmi48 please merge this when you feel it has been validated enough (and merge coq-community/aac-tactics#94). I can take care of rolling out the changes to Coq-community projects. We may consider adding a topic/tag for repos to track that they are using Nix or Docker CI, e.g., nix-ci, docker-ci.