search

coq / coq.github.io

Source files of the coq.inria.fr website
https://coq.inria.fr/
Other
15 stars 37 forks source link

remove deprecation #183

Closed Alizter closed 2 years ago

Alizter commented 2 years ago

I removed a deprecated namespace in yamlpp.mll and the newly generated yamlpp.ml no longer emits a warning.

Zimmi48 commented 2 years ago

I have no idea how this works, so I cannot understand the changes to the lines starting with a #, but I can trust you and merge this. In fact, I can even add you to the @coq/website-maintainers team if you wish.

Alizter commented 2 years ago

Well, I only changed yamlpp.mll but after make it updated yamlpp.ml which it didn't do before. I therefore commited both. I am also not 100% sure I haven't broken anything, so a review from @coq/website-maintainers would be helpful.

I wouldn't mind joining that team also.

Zimmi48 commented 2 years ago

OK, I see, thanks! Unfortunately, I don't think anyone currently has maintenance expertise in this code. We barely touch it until it goes away with a full website rework. On my machine it works fine with the change, so it looks good to go.

I'll add you to the team.