coq / platform

Multi platform setup for Coq, Coq libraries and tools
Creative Commons Zero v1.0 Universal
187 stars 49 forks source link

Add coq-dpdgraph to the Coq Platform #12

Closed palmskog closed 3 years ago

palmskog commented 4 years ago

Coq-Dpdgraph is a tool for building dependency graphs between Coq objects.

This is a Coq plugin which extracts out dependencies between terms. It can be used to output graphs of term relationships, and to find unused definitions and lemmas. Coq-dpdgraph has had consistent releases for new versions of Coq and is part of Coq's CI.

Since it provides useful and unique functionality to Coq project maintainers, I propose that coq-dpdgraph is included in the Coq Platform.

The maintainer of coq-dpdgraph is @ybertot.

Karmaki commented 3 years ago

Hi, I just have been noticed about this request by @MSoegtropIMC email. Since I do not use Coq myself anymore, there is very little chance that coq-dpdgraph evolves anymore, but, with the frequent help of @ybertot, I try to merge all pull request from the kind maintainers as soon as I can to keep it usable on newer Coq versions. I am happy that the Coq users find it useful, and of course agree to see it included in the Coq Platform. Do I have to do something on my side?

palmskog commented 3 years ago

@Karmaki since I believe @ybertot already handles tagging and opam packages of coq-dpdgraph for new Coq releases (and platform maintainers can potentially also help out with that), I don't think anything additional from your side is required, but @MSoegtropIMC can confirm.

Zimmi48 commented 3 years ago

@Karmaki Since you are not using Coq anymore and coq-dpdgraph is already collaboratively maintained, would it make sense to transfer the repository to coq-community?

Karmaki commented 3 years ago

@Zimmi48 : yes, it would be a good idea. Who does this? I guess there must be some kind of approval or something?

Zimmi48 commented 3 years ago

Yes, the process is:

Karmaki commented 3 years ago

OK, thanks. Not sure to have time to do this right now, but I'll probably (hopefully) do it next week.

ybertot commented 3 years ago

I have family obligations this week, but I already started preparing a new version for coq-dpdgraph. As I understand that Karmaki agrees with it, I will also do the necessary to have the project transferred to coq-community. It should be done by October 6th.

Karmaki commented 3 years ago

OK: thanks a lot to handle that @ybertot \o/

MSoegtropIMC commented 3 years ago

@ybertot : the 8.14 release of Coq Platform will likely happen some time in November, so there is time and no need to hurry. What I am interested in is a long term commitment. In Coq Platform we try to provide a stable foundation for Coq developments to users. Users should be able to rely on that packages are maintained.

MSoegtropIMC commented 3 years ago

@Zimmi48 : with "maintainer agreement" I don't mean an author agreement (which is not really needed for open source SW), but an agreement that someone is willing to maintain it according to the spirit of the Coq Platform charter. I would say this is still in discussion, so I added the label back.

MSoegtropIMC commented 3 years ago

I take the "Status" comment:

Status: It is maintained, part of Coq-CI, with a new version produced for each release of Coq, thanks to the kind help of the main Coq developers.

in (https://github.com/coq-community/manifesto/issues/131) as maintainer agreement and will move coq-dpdgraph to the "full" level.

MSoegtropIMC commented 3 years ago

Sorry, I just saw that the version number is still 0.X, so by default it will go into the "extended" level.

In case you want to change this for 2021.09 please provide a justification.

The package will automatically be moved to the "full" level if the version number reaches 1.X in the future.

Zimmi48 commented 3 years ago

@ybertot @Karmaki Since there are no plans for feature changes for this package, only baseline maintenance, wouldn't it make sense to move the version to 1.0?

Karmaki commented 3 years ago

Yes. Good idea. (but I cannot do it right now...)

MSoegtropIMC commented 3 years ago

No need to hurry - the next release is planned for November.

MSoegtropIMC commented 3 years ago

Of course if you are saying you will just label it 1.0 without (substantial) changes, I can include it into "full" right away. This is about the spirit, not about numbers.

Karmaki commented 3 years ago

Yes, since it has been stable for a while and there are no plan to make new developments, I think the only modification will be to label it 1.0. Do you agree @ybertot ?

ybertot commented 3 years ago

I agree that renaming the version to 1.0 is sensible, because this mirrors the stability of the basic functionality we have been maintaining over the recent years.

ybertot commented 3 years ago

replying to a comment of @MSoegtropIMC of 3 days ago, I will be happy to commit to maintaining this package. Still, I would like this to be handed over to other volunteers, as soon as possible.

Yves

MSoegtropIMC commented 3 years ago

@ybertot : thanks for the commitment!

I moved coq-dpdgraph from "extended" to "full" in PR: (https://github.com/coq/platform/pull/147).