coq / platform

Multi platform setup for Coq, Coq libraries and tools
Creative Commons Zero v1.0 Universal
189 stars 50 forks source link

Add a pick for 8.19.2 with the Ltac2 debugger (preview) #429

Closed jfehrle closed 1 week ago

jfehrle commented 2 months ago

This works now.

I didn't include the patch file PR19247-ported-Fix-coqide-compilation-with-lablgtk-3.1.5-on-windows.patch because I previously included that commit in my branch.

MSoegtropIMC commented 2 months ago

The opam file for coqide misses the dependency. The original one has it here:

https://github.com/ocaml/opam-repository/blob/abac1deff0ec6249cf93f6b25ffdc49ae1caf04c/packages/coqide/coqide.8.19.2/opam#L24

You should copy the original one and deviate from it only as much as required.

jfehrle commented 2 months ago

OK, this works for me, I think it's good. If you merge soon, will this pick be included when you release CP 8.19? If so, perhaps the announcement of CP 8.19 could briefly mention the Ltac2 debugger and say that more information on it will be sent out shortly (by me)?

Thanks.

MSoegtropIMC commented 3 weeks ago

@jfehrle : can you please rebase to latest main?

jfehrle commented 3 weeks ago

I think I got it. I had some misconfiguration for this git project :-(

jfehrle commented 3 weeks ago

If you have no further comments, perhaps you could merge this soon? Thanks.

jfehrle commented 1 week ago

I took out the doc commit and updated a few files to match 8.19.2. So I think ready now.

MSoegtropIMC commented 1 week ago

@jfehrle : thanks!

Sorry, there is one more thing I missed (I got interrupted during my last review): your pick file became outdated vs. main. When you rebase you need to manually merge over changes to variants of pick files.

Please update your pick file to the changes in package-pick-8.19~2024.10.sh.

jfehrle commented 1 week ago

I think I got it, thanks. I can squash before the merge.

MSoegtropIMC commented 1 week ago

@jfehrle : thanks - yes looks good.

And yes, please squash.

MSoegtropIMC commented 1 week ago

I cancel the CI run, so that the squashed CI run gets through faster (otherwise it would have to wait).

jfehrle commented 1 week ago

Squashed