Closed jfehrle closed 1 week ago
The opam file for coqide misses the dependency. The original one has it here:
You should copy the original one and deviate from it only as much as required.
OK, this works for me, I think it's good. If you merge soon, will this pick be included when you release CP 8.19? If so, perhaps the announcement of CP 8.19 could briefly mention the Ltac2 debugger and say that more information on it will be sent out shortly (by me)?
Thanks.
@jfehrle : can you please rebase to latest main?
I think I got it. I had some misconfiguration for this git project :-(
If you have no further comments, perhaps you could merge this soon? Thanks.
I took out the doc commit and updated a few files to match 8.19.2. So I think ready now.
@jfehrle : thanks!
Sorry, there is one more thing I missed (I got interrupted during my last review): your pick file became outdated vs. main. When you rebase you need to manually merge over changes to variants of pick files.
Please update your pick file to the changes in package-pick-8.19~2024.10.sh
.
I think I got it, thanks. I can squash before the merge.
@jfehrle : thanks - yes looks good.
And yes, please squash.
I cancel the CI run, so that the squashed CI run gets through faster (otherwise it would have to wait).
Squashed
This works now.
I didn't include the patch file
PR19247-ported-Fix-coqide-compilation-with-lablgtk-3.1.5-on-windows.patch
because I previously included that commit in my branch.