search

coq / vscoq

Visual Studio Code extension for Coq
MIT License
335 stars 68 forks source link

[coq] Adapt to coq/coq#19193 #787

Closed ejgallego closed 3 months ago

ejgallego commented 4 months ago

Change is already inside a 8.20 conditional.

rtetley commented 4 months ago

It fails on coq-master which is normal since the coq pin hasn't changed in the flake.nix so it doesn't contain the latest change. Once https://github.com/coq/coq/pull/19193 is merged we beed to update the coq pin and it will be fine.

SkySkimmer commented 3 months ago

Please merge now

SkySkimmer commented 3 months ago

@gares @rtetley ping

SkySkimmer commented 3 months ago

also need https://github.com/coq-community/vscoq/pull/778 to be comptible with coq master

rtetley commented 3 months ago

Closing in favour of #778 Pushed the changed there while fixing some opt comp flags