search

coq / vscoq

Visual Studio Code extension for Coq
MIT License
335 stars 68 forks source link

allows newer ppx_yojson_conf version #833

Closed CodiePP closed 2 months ago

CodiePP commented 2 months ago

in newer ppx_yojson_conv versions apparently for deriving yojson types of primitives one has to include some declarations. I was using v0.17 and this solved the compilation errors.

the opam file had a duplicate entry for the ppx_yojson_conv library. 🍤

gares commented 2 months ago

There was an upper bound, dunno why, but I'd be happy to remove it. Unfortunately Ci is not picking the version you mention up, maybe because ocaml is 4.13? We can surely switch to 4.14 in the opam job. Would you mind trying?

CodiePP commented 2 months ago

yes, seems to work fine. I recompiled using OCaml 4.14.2

ocaml                 4.14.2      The OCaml compiler (virtual package)
ppx_yojson_conv       v0.16.0     [@@deriving] plugin to generate Yojson conversion functions
ppx_yojson_conv_lib   v0.16.0     Runtime lib for ppx_yojson_conv

and it picked up v0.16.0 which let the dependent packages compile. also, rebased on main.