search

coqui-ai / STT

🐸STT - The deep learning toolkit for Speech-to-Text. Training and deploying STT models has never been so easy.
https://coqui.ai
Mozilla Public License 2.0
2.27k stars 275 forks source link

Update dotnet client to support netstandard2.0, netstandard2.1, net5.0 and net6.0 #2271

Closed stepkillah closed 2 years ago

stepkillah commented 2 years ago

Migrate to netstandard2.0 and add support for net5.0, net6.0 Also, I updated net461 to net48 because 4.6.1 is out of support

does the new repo have configured pipelines for dotnet? I only found an old one that uses taskcluster

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

reuben commented 2 years ago

Thanks for the PR!

does the new repo have configured pipelines for dotnet? I only found an old one that uses taskcluster

We do not. The .NET CI is still missing from the GitHub Actions transition.

stepkillah commented 2 years ago

Thanks for the PR!

does the new repo have configured pipelines for dotnet? I only found an old one that uses taskcluster

We do not. The .NET CI is still missing from the GitHub Actions transition.

I can try to add ones in this or better in separate PR later

reuben commented 2 years ago

That'd be fantastic!

reuben commented 2 years ago

Looks like there are some linter errors, could you set-up the linter and run it on your files? You should be able to run python .pre-commit-2.11.1.pyz run --all-files to have it fix the problem for you, then git commit --amend and force push.

stepkillah commented 2 years ago

@reuben sorry, missed to do amend and did another commit :(