Closed reuben closed 1 year ago
Hi Kiziltan,
Again tried to accommodate the font sizes. This is the font size at 1080p.
Please let me know your thoughts
Thanks, Nathan
Can we try a similar approach to https://github.com/coqui-ai/coqui-ai.github.io/issues/492#issuecomment-1483282175 that we can adjust font sizes conditionally?
Perhaps if we can see how the code generates output in various resolutions altogether it can be much easier and effective to decide.
@reuben @samuelF18 fyi
Can we try a similar approach to #492 (comment) that we can adjust font sizes conditionally?
@nathanjassi could you comment?
ping @timb90 @nathanjassi ?
Hi Kiziltan,
I believe I have implemented the best version when taking the Zendesk garden theme into account.
Typically you would set custom breakpoints, however because of the theme I am limited to the available breakpoints I can use.
My example shows:
you have to specify 'up' or 'down' followed by a screen size defined in the theme. Currently it is the values of 's', 'm', 'l' 'xl' that correspond to a breakpoint value. The actual breakpoint value is configured somewhere in the theme files but modifying can cause a multitude of other problems if not implemented correctly.
You can read more about it here: https://garden.zendesk.com/components/utilities ![image](https://user-images.githubusercontent.com/17572214/229143807-7b705730-3025-4172-bf4e-114e6e6f74c8.
My code example is actually the code we used for the hero font size so I have already tried following your suggestion
Based on the above restriction I did my absolute best to make the font appear nicely and meet the responsive design requirement.
Please let me know your thoughts and please mark as closed if you agree with the above.
Thank you. Nathan.
Thank you Nathan. Let's check it out on the implemented version.
Looks good on 1920x1080
"game developers" should not be broken, and neither should "save weeks".