search

coqui-ai / stt-model-manager

Coqui STT Model Manager - install, manage and try out Coqui STT models from the Model Zoo
https://coqui.ai
Mozilla Public License 2.0
24 stars 17 forks source link

Renaming of POSTed JSON parameters #1

Open kdavis-coqui opened 3 years ago

kdavis-coqui commented 3 years ago

Could we rename the POSTed parameters from

{
        "name": "test_model",
        "language": "english",
        "version": "0.0.1",
        "creator": "reuben",
        "acoustic": "https://github.com/coqui-ai/STT-models/releases/download/english/coqui/v0.9.3/model.pbmm",
        "scorer": "https://github.com/coqui-ai/STT/releases/download/v0.9.3/coqui-stt-0.9.3-models.scorer"
}

to

{
        "name": "test_model",
        "language": "english",
        "modelVersion": "0.0.1",
        "modelCreator": "reuben",
        "acousticModelURL": "https://github.com/coqui-ai/STT-models/releases/download/english/coqui/v0.9.3/model.pbmm",
        "scorerURL": "https://github.com/coqui-ai/STT/releases/download/v0.9.3/coqui-stt-0.9.3-models.scorer"
}

Just to be more specific, as there are model versions and code version, code creators and model creators, and "acoustic" isn't the model but its URL similarly for "scorer".

Also as a suggestion we should also add the code version too, e.g. something like

{
        ...
        "codeVersion": "0.9.3",
        ...
}

to help with future proofing things.

reuben commented 3 years ago

Yep, of course :)

reuben commented 3 years ago

Actually as we'll be switching to the official model card JSON format eventually we should stick to the official schema.