search

coracle-social / coracle

A Nostr client that makes relays a first-class concept
https://app.coracle.social
MIT License
269 stars 63 forks source link

Better bitcoin integration #327

Closed staab closed 3 months ago

staab commented 5 months ago

Zaps need to be better for V4V people.

stackingsaunter commented 4 months ago

Any idea why bitcoin connect is not integrated anymore?

staab commented 4 months ago

I did it sort of halfway, and it created some confusion/overloading when zapping. It's still in there, just not in settings anymore. If you have webln it'll be used, but as a fallback bitcoin connect will be used. Hopefully I can do a better job the next time around.

stackingsaunter commented 4 months ago

Thanks for info @staab! If you use BC only as a fallback, then you don't allow users with webln extensions to connect through NWC for example, which may be for some desirable. If this is something that can be improved on BC side, let us know, also join our NWC builders discord, we have a bitcoin connect channel there.

staab commented 4 months ago

Yes, I'm beginning to realize that, so I could get rid of the webln integration entirely and just use BC? That would be an easy change to do. Would it make it easier to implement zap splits? I haven't ever really had time to prioritize zaps, so it's always been a back burner project for me.

rolznz commented 4 months ago

@staab it's ok to use Bitcoin Connect on its own as it also allows you to connect to a WebLN browser extension (which will provide the WebLN object).

Zap splits are made simple with WebLN (which is what Bitcoin Connect provides) because users do not need to confirm each payment. You can do simultaneous payments up to a budget provided by the user (NWC / setting a budget in the Alby extension / Lnbits account limit etc).

staab commented 4 months ago

Thanks, that's very helpful, I'll look into getting this into a release sooner rather than later.

staab commented 3 months ago

This will be part of the next release.