coral-erm / coral

CORAL ERM main repository
http://coral-erm.org/
Other
52 stars 65 forks source link

[747] Updates for jquery datepicker plugin and javascript includes cleanup #749

Closed jsavell closed 7 months ago

jsavell commented 8 months ago

This PR:

The latest, original version of the plugin appears to include all the modern jquery updates that were provided by the forked version along with additional improvements and fixes. I haven't found any issues testing these changes locally.

andyp-uk commented 8 months ago

@jsavell thanks for this. How much testing do we need to do? Can you please give us some guidance? Will these changes impact other modules apart from Resources?

jsavell commented 8 months ago

Hi, this date picker plugin is shared across multiple/all modules, so the fix impacts/benefits all usages of the '.date-pick' class hook.

The javascript includes clean up is isolated to the resource.php file itself.

For testing, just verifying that the date picker pop ups still appears should be enough. If your installation wasn't affected by the DST bug, there shouldn't be any visible differences before/after.

In applying this PR to this 'ERM-63-modern-jquery-update-with-php8' branch, I did find a case where the date picker pop up wasn't applying properly: https://github.com/coral-erm/coral/blob/ERM-63-modern-jquery-update-with-php8/management/ajax_forms.php#L121

I tested this issue on the parent 'ERM-63-modern-jquery-update-with-php8' without my update, and the problem was already present. I also tested on the Coral Demo site and the problem was not present. I've opened a separate PR to address that issue.