coral-xyz / anchor

⚓ Solana Sealevel Framework
https://anchor-lang.com
Apache License 2.0
3.68k stars 1.35k forks source link

Inconsistent namespace `::` usage for sighash and account discriminants #249

Closed armaniferrante closed 3 years ago

armaniferrante commented 3 years ago

Domain separation is done by prefixing account discriminators and instruction hashes with a <namespace> prei-image. Instructions are prefixed with <namespace>:: where as accounts are prefixed with <namespace>:. Colon count should be consistent.

armaniferrante commented 3 years ago

Addressed by https://github.com/project-serum/anchor/pull/321.