search

coral-xyz / backpack

🎒 Next level crypto wallet
https://backpack.app
GNU General Public License v3.0
1.32k stars 796 forks source link

remove zustand dependency from @coral-xyz/common #2893

Open tomlinton opened 1 year ago

tomlinton commented 1 year ago

We need to remove this dependency because it also requires react and thus makes backpack-api dependent on react via @coral-xyz/common

This should be reverted https://github.com/coral-xyz/backpack/pull/2892

tomlinton commented 1 year ago

Also this

Screenshot 2023-02-22 at 11 12 50 PM
hkirat commented 1 year ago

Yeah common shouldnt contain any server/frontend library. server libraries should reside in common-backend frontend libraries should reside in common-react If frontend and only used by mobile - common-mobile

hkirat commented 1 year ago

Just to point out we reverted hot reloading a while back and this might come after that happens

armaniferrante commented 1 year ago

Appears gone to me. Can re-open if it comes back.