search

coral-xyz / backpack

🎒 Next level crypto wallet
https://backpack.app
GNU General Public License v3.0
1.35k stars 809 forks source link

requests to backpack-api that generate an exception don't return a http response #3264

Open tomlinton opened 1 year ago

hkirat commented 1 year ago

I've always suspected there is something wrong here - https://github.com/coral-xyz/backpack/blob/master/backend/native/backpack-api/src/index.ts#L75

The res argument doesnt look like it gets the axios result

hkirat commented 1 year ago

My suspicion seems to be wrong this is working as expected

armaniferrante commented 1 year ago

Can we close this then?

tomlinton commented 1 year ago

I think this still happens with the deployment, but @hkirat means it doesn't happen locally.

hkirat commented 1 year ago

I meant my suspicion that I mentioned here - https://github.com/coral-xyz/backpack/issues/3264#issuecomment-1463049839 is wrong (The middleware here - https://github.com/coral-xyz/backpack/blob/master/backend/native/backpack-api/src/index.ts#L75 is working as expected). So this still happens, probably happens locally as well