search

coral-xyz / sealevel-attacks

☠️ Common Security Exploits and Protections on Solana
507 stars 95 forks source link

Is secure better than recommended? #8

Closed zfedoran closed 2 years ago

zfedoran commented 2 years ago

Each example contains 3 folders: insecure, recommended, and secure. It might be the alphabetical ordering, but it isn't quite clear which folder is "best".

One interpretation is that recommended means the minimum recommendation and that secure is better. The other is that secure is the minimum required to stop the attack but recommended is better.

Is recommended > secure or is secure > recommended.

edit: lol I'm not looking for an answer, I'm looking for a discussion whether it's just me having these thoughts and on how to make it more clear (if needed). My initial thoughts are adding a number to the folder name, or replacing secure with minimum, or a simple note on the README.md.

rahulsoshte2 commented 2 years ago

I think your question is answered here https://github.com/project-serum/sealevel-attacks/issues/1

zfedoran commented 2 years ago

@rahulsoshte2 Ha! Lol I didn’t see that issue. But I think this proves I’m not alone 😅