Fix build: Start using GitHub Actions + Replace test image URL

coralnet / pyspacer

Python based tools for spatial image analysis

MIT License

6 stars 2 forks source link

Fix build: Start using GitHub Actions + Replace test image URL #48

Closed StephenChan closed 2 years ago

StephenChan commented 2 years ago

(Edit) PR summary:

Switch from Travis CI to GitHub Actions; for issue #47.
- In the process, saw that building scikit-image no longer worked for some reason. So this PR fixes that by updating scikit-image, and in the process has to drop Python 3.5 (it's EOL since 2020 anyway).
The wisc.edu baboon image URL, used in some unit tests, is no longer available. This PR switches the URL to a Wikimedia image of roughly similar size.

Originally wanted to make this two PRs, but both tasks were required for the build to pass, which is required to merge PRs.

(Original PR text below:)

For issue #47.

StephenChan commented 2 years ago

scikit-image failed to build: ModuleNotFoundError: No module named 'numpy': https://github.com/beijbom/pyspacer/runs/5561549826

This old Travis build with the same versions of numpy and scikit-image succeeded: https://travis-ci.org/github/beijbom/pyspacer/jobs/725155186

That old build's pip was 19.3, current pip is 22.0.4. I'll see if 19.3 makes it work again, at least to help understand what's happening.

StephenChan commented 2 years ago

I told it to use pip 19.3 and it used pip 21.1.1 instead. No idea why, but I guess that route goes out the window.

We're on scikit-image 0.15.0. A comment in this issue suggests that scikit-image 0.17.x (but not 0.18.x) may improve the numpy import situation in setup.py - so 0.17.x could be worth a shot: https://github.com/scikit-image/scikit-image/issues/1329

StephenChan commented 2 years ago

@beijbom I ended up moving PR #45's commit over to this PR, so that it's just a single PR which fixes the build.

StephenChan commented 2 years ago

@beijbom Thanks - could you also remove Travis CI from the "required statuses" for PRs? Should be in the repo settings.

StephenChan commented 2 years ago

(And forgot to update Dockerfile, oops)

StephenChan commented 2 years ago

@beijbom Reminder - could you 1) remove Travis CI from "required statuses" and 2) re-approve the PR? (I didn't realize adding another commit would dismiss your previous review as stale.)

beijbom commented 2 years ago

Fixed. Sorry for the delay.

StephenChan commented 2 years ago

Np, thanks!