Debugging with `request` is frustrating

coralogix / nodejs-coralogix-sdk

Coralogix NodeJS SDK

https://coralogix.com/integrations/coralogix-nodejs-integration/

Apache License 2.0

6 stars 11 forks source link

Debugging with `request` is frustrating #6

Open benjamingr opened 5 years ago

benjamingr commented 5 years ago

Coralogix logger uses request internally - and .json, this tries to JSON.parse inside a try/catch internally which triggers "pause on all exceptions" a ton of times:

Screen Shot 2019-08-16 at 16 18 54

This can be fixed in several ways:

returning valid JSON from /api/v1/logs (for example by returning "OK" and not OK).
Calling .text() and not .json.
Not using request for this and using http internally.

EldarAliiev commented 3 years ago

We are in the transition phase to move out from request library.

omril1 commented 2 years ago

We are in the transition phase to move out from request library.

Hi, any progress on that?

benjamingr commented 2 years ago

@yaircohendev this SDK in general is pretty neglected, uses loggers one shouldn't (bunyan/winston) instead of the modern ones (like pino), uses RxJS needlessly, doesn't clean up properly and a bunch of other things that modern JS code bases have generally stopped doing.

It might be a good idea to either deprecate this SDK (and direct people towards something like pino-elasticsearch and the ES API and provide a proxy/security for browser usage or alternatively fix it to be at a more industry-standard place.