search

coralogix / terraform-coralogix-aws

Coralogix AWS Integrations modules for Terraform.
https://registry.terraform.io/modules/coralogix/aws/coralogix
Apache License 2.0
7 stars 27 forks source link

Feature: custom names for IAM Role and CloudWath log #155

Closed Gershon-A closed 1 week ago

Gershon-A commented 5 months ago

Hello! I'm deploying to different regions. Can we have customizable IAM Role and CloudWatch log group names? Thank's

guyrenny commented 5 months ago

Hi @Gershon-A , can you please let me know what is the module you are referring to (coralogix-aws-shipper, firehose, ...)?

Gershon-A commented 5 months ago

@guyrenny Hello sorry for delay. In my case the module is cloudwatch_firehose_metrics_coralogix , but this seems true for others as well.

ryantanjunming commented 5 months ago

Hi @Gershon-A, which role names in particular and how would they be grouped

I've named most of the aws_iam_role and loggroups to be synonymous with the supporting resource like the firehose stream name e.g. var.firehose_stream so that value can be name according to the region.

ryantanjunming commented 1 week ago

fixed with https://github.com/coralogix/terraform-coralogix-aws/pull/175