coralogix / terraform-coralogix-aws

Coralogix AWS Integrations modules for Terraform.
https://registry.terraform.io/modules/coralogix/aws/coralogix
Apache License 2.0
5 stars 24 forks source link

Option to give region variable for s3 bucket for lambda code in s3 integration #46

Closed sanjeevpandey19 closed 1 year ago

sanjeevpandey19 commented 1 year ago

Issue By default s3 bucket for lambda zip code is configured to get the region from the data block, which means that lambda itself has to be created in that region.

In a situation where the organization uses for example ap-east-1 and has to create lambda there only that case the data block fails as the s3 bucket "coralogix-serverless-repo-ap-east-1" doesn't exist and the region is being fetched from data blog can't be overridden

Ref - https://github.com/coralogix/terraform-coralogix-aws/blob/master/modules/s3/main.tf#L76

What we can use instead We should give the option to pass a variable such as "coralogix_serverless_repo_region" so that people using ap-east-1 or other regions have the option to choose what region they want to use to fetch lambda code from Or The Coralogix team will have to create a bucket in all the region with lambda code

sanjeevpandey19 commented 1 year ago

can we support the ap-east-1 region as well here ?? not sure how that works when we deploy coralogix-aws integration with cloud formation but with terraform lambda and lambda code repo is supposed to be in the same region.

In our case, we are using ap-east-1 but the coralogix-serverless-repo doesn't exist in ap-east-1 rather it's in eu-central-1 thus terraform throws an error

sanjeevpandey19 commented 1 year ago

relates to issues/90

sanjeevpandey19 commented 1 year ago

This is Solved