search

coralproject / pillar

Deprecated: Service layer for the Coral ecosystem
Other
4 stars 1 forks source link

Fix memory leak issue in deploy process #159

Closed jde closed 8 years ago

jde commented 8 years ago

A memory leak issue as discovered in our docker compose install model and solved in #143. Integrate this fix into our deployment files so that it doesn't happen for future clients.

alexbyrnes commented 8 years ago

This is in https://github.com/coralproject/trust/pull/1 as a cron job which is how I implemented it internally. Do you have a different destination in mind other than /trust?

jde commented 8 years ago

If there is code that we know should be run when the app is spun up, let's add it to the deployment flow.

Also, let's add this note to the documentation under Trust install. @aiboyles can assist.

alexbyrnes commented 8 years ago

@jde where is the deployment flow? Please let me know where I can commit the change to close this.

jde commented 8 years ago

The Trust install is here: https://github.com/coralproject/Proxy

alexbyrnes commented 8 years ago 
Permission to coralproject/Proxy.git denied to alexbyrnes
alexbyrnes commented 8 years ago

Thanks @kgardnr

coralproject/proxy pull 13

alexbyrnes commented 8 years ago

@edefikh please accept or reject if you think the switch from rabbitmq is going to be too soon.

alexbyrnes commented 8 years ago

merge accepted, closing