coralproject / talk

A better commenting experience from Vox Media
https://coralproject.net
Other
1.89k stars 355 forks source link

When premod is turned on site wide, it should show that pre-mod is on in the individual stream setting as well #1049

Closed kgardnr closed 6 years ago

kgardnr commented 6 years ago

Expected behavior

If "Pre-mod" is on site-wide, it should show in each individual stream's settings.

Actual behavior

It's not reflecting the global setting in the individual settings.

Steps to reproduce behavior

  1. Turn on "Pre-mod" via Admin > Configure > Moderation Settings
  2. Go to an individual article and click on the Configure tab
  3. See that the "Pre-mod" setting is unchecked; it should be checked
MisaOgura commented 6 years ago

I'll start working on this 👍

kgardnr commented 6 years ago

Welcome @MisaOgura! That sounds great!

MisaOgura commented 6 years ago

I'm no longer working on this one, please feel free to tackle this. sorry @kgardnr 😞 really nice project though 👍

kgardnr commented 6 years ago

Awww that's a bummer @MisaOgura! If you change your mind or want us to recommend something else that might be interesting, just let us know - thanks for your support and interest!! 🎉

AnneTheAgile commented 6 years ago

@kgardnr I see here that the variable 'moderation' is used but not defined anywhere previously in this file. https://github.com/coralproject/talk/blob/9e486f3a9dfeca857a55c8a19819fb960378284c/graph/mutators/comment.js#L393 Would there be global variables lurking? Or would this indicate the fix is to initialize 'moderation'?

kgardnr commented 6 years ago

Hi @AnneTheAgile! It's a configuration variable yes called PREMOD - you can see that here:

https://github.com/coralproject/talk/blob/99daa0b2c92e140894545b1820d5df680f29a5f5/graph/typeDefs.graphql#L244

kgardnr commented 6 years ago

Hey @AnneTheAgile! If you still wants to work on this, just make sure you follow the upgrade instructions for v4.0.0: https://coralproject.github.io/talk/migration/4/

kgardnr commented 6 years ago

This is fixed