coralproject / talk

A better commenting experience from Vox Media
https://coralproject.net
Other
1.89k stars 354 forks source link

Update troubleshooting.md to showcase a workaround for issue #4375 #4389

Closed oliver-dvorski closed 10 months ago

oliver-dvorski commented 1 year ago

What does this PR do?

These changes will impact:

What changes to the GraphQL/Database Schema does this PR introduce?

None

Does this PR introduce any new environment variables or feature flags?

No

Where any tests migrated to React Testing Library?

No

netlify[bot] commented 1 year ago

Deploy Preview for gallant-galileo-14878c ready!

Name Link
Latest commit 0a5a2d0e7181c9d10c1db21440df3d05016eeb4e
Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/654b775536174700086b5826
Deploy Preview https://deploy-preview-4389--gallant-galileo-14878c.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nick-funk commented 10 months ago

Thanks for taking the time to write this up.

As this isn't something we currently yet support, but would like to, we don't want to post a work around that we don't have time to test the full ramifications of how it might be used across our open source and SaaS services deployments.

While this work around is possibly viable for everyone, we don't have the time to vet it properly, and once something is written up and documented, whether it is labelled as a temporary work around or not, some clients or open source users may expect it to be fully supported.

Hopefully, we'll have time at some point to fix this issue so it doesn't require a work-around. We know that The Verge has Coral inside of a position: fixed div comment drawer without needing this work-around, so there may be another solution to this problem that we can include in our documentation.