coralproject / talk

A better commenting experience from Vox Media
https://coralproject.net
Other
1.89k stars 355 forks source link

[CORL-2934]: DSA - updates to design and copy #4394

Closed kabeaty closed 10 months ago

kabeaty commented 10 months ago

What does this PR do?

These changes include various updates to design and copy related to reporting and moderating illegal content for DSA. They include:

These changes will impact:

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

To test validation updates for adding multiple additional comments to a report You can test this PR by clicking on Report for a comment in the stream and then going to its illegal content report form. Add additional comments to the report form. Test that if valid URL for a valid comment, they are added as expected. If you try to add a comment twice, you see the appropriate error. If you try to add an invalid URL, you see the appropriate error. If you add a valid URL with an invalid comment id (comment doesn't exist for that id), then you see the appropriate error. If you add a valid URL for a valid comment id but the user has already previously reported that comment for illegal content, then you see the appropriate error.

Design updates to look at

Where any tests migrated to React Testing Library?

How do we deploy this PR?

kabeaty commented 10 months ago

Duplicate and invalid comment URLs work perfectly! I'm not seeing the ability to remove a comment after adding it though.

Thanks! Hmm, on the illegal content report form, click Add additional comments, add a comment url there, click Add comment URL, and then you should see the comment url added. You should then see a Delete button with a little trash bin to the right of the url you added that, when clicked, deletes it.