search

coralproject / talk

A better commenting experience from Vox Media
https://coralproject.net
Other
1.89k stars 355 forks source link

DSA - fix to send through rejection reason when deleting user and comments #4406

Closed kabeaty closed 10 months ago

kabeaty commented 10 months ago

What does this PR do?

This sends through a rejection reason when deleting a user and their comments. This ensures that it will go through and delete the comments without error.

These changes will impact:

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

You can create a User 1, have them comment. Then have another User 2 report their comment for illegal content. Then have the User 1 request their account be deleted. Go in and update their scheduled deletion date to be now. Run Coral with jobs so that they will be deleted (might want to update to make account deletion run more often in accountDeletion.ts so you don't have to wait). See that the user is successfully deleted with no errors. The illegal content report against their comment should now be set to status Void.

Where any tests migrated to React Testing Library?

How do we deploy this PR?

kabeaty commented 10 months ago

Closing in favor of resolving in https://github.com/coralproject/talk/pull/4405/