DSA notifications: handle not found comment - Githubissues

coralproject / talk

A better commenting experience from Vox Media

https://coralproject.net

Other

1.89k stars 354 forks source link

DSA notifications: handle not found comment #4411

Closed nick-funk closed 11 months ago

nick-funk commented 11 months ago

What does this PR do?

Handles the case when a comment no longer exists in the database when resolving notifications in graphql.

These changes will impact:

[X] commenters
[X] moderators
[X] admins
[ ] developers

What changes to the GraphQL/Database Schema does this PR introduce?

None

Does this PR introduce any new environment variables or feature flags?

No

If any indexes were added, were they added to `INDEXES.md`?

None

How do I test this PR?

enable DSA in config
create a new user (you're deleting them soon)
post a comment
have a mod/admin reject the comment
check the user's notifications to see that they have a rejection notification for the comment
delete the comment using mongo
go back to the user's notifications
see that the notification exists, but the referenced comment is not longer there

Where any tests migrated to React Testing Library?

No

How do we deploy this PR?

Merge into DSA epic branch

netlify[bot] commented 11 months ago

Deploy Preview for gallant-galileo-14878c canceled.

Name	Link
Latest commit	294fb31a73c8cf7bb3a7d3774b2b64816a36e670
Latest deploy log	https://app.netlify.com/sites/gallant-galileo-14878c/deploys/655bd0657082e40008792980