search

coralproject / talk

A better commenting experience from Vox Media
https://coralproject.net
Other
1.89k stars 354 forks source link

Fix/localize rejection reason #4413

Closed marcushaddon closed 11 months ago

marcushaddon commented 11 months ago

What does this PR do?

This PR localizes the string passes as the explanation of the rejection reason when rejecting a users comments as part of the account deletion flow.

These changes will impact:

What changes to the GraphQL/Database Schema does this PR introduce?

None.

Does this PR introduce any new environment variables or feature flags?

No.

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

Change your tenants locale to something other than english. In the FTL file for that locale, add a translation for common-accountDeleted. Delete a user's account, observe that the moderation actions for the resulting rejected comments have a detailedExplanation field matching your FTL entry.

Where any tests migrated to React Testing Library?

No.

How do we deploy this PR?

No special considerations should be needed

netlify[bot] commented 11 months ago

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
Latest commit 338a9c241cf7ed00d4dc0a2ebb78e811279bd893
Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/655bda7dc1f9ae0008f2a474