coralproject / talk

A better commenting experience from Vox Media
https://coralproject.net
Other
1.89k stars 354 forks source link

Fix: DSA - reviewed report notifications copy update #4417

Closed kabeaty closed 11 months ago

kabeaty commented 11 months ago

What does this PR do?

Updates the copy and bolding for notifications for reviewed DSA reports.

These changes will impact:

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

Make an illegal content decision on a report. Check the notification in the reporter's notifications tab and see that it has the correct updated copy and bolded text.

Make a legal content decision on a report. Check the notification in the reporter's notifications tab and see that it has the correct updated copy and bolded text.

Where any tests migrated to React Testing Library?

How do we deploy this PR?

netlify[bot] commented 11 months ago

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
Latest commit 905fbb8252cf961113b8d5ce06444eec3a9972b2
Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/655cd4aceddc2c000866f3e7
nick-funk commented 11 months ago

Approving, as this works in Chrome, but FireFox doesn't like the <strong/> formatting for some reason.

Looks like if you add this to DSAReportDecisionMadeNotificationBody.css it will fix <strong/> formatting for FF:

.body > span > strong {
  font-family: var(--font-family-primary);
  font-weight: var(--font-weight-primary-semi-bold);
  font-size: var(--font-size-2);
}
kabeaty commented 11 months ago

font-family: var(--font-family-primary); font-weight: var(--font-weight-primary-semi-bold); font-size: var(--font-size-2);

Updated; thanks for catching!