coralproject / talk

A better commenting experience from Vox Media
https://coralproject.net
Other
1.89k stars 355 forks source link

Fix translation for comment rejection reason when user is banned #4444

Closed kabeaty closed 9 months ago

kabeaty commented 9 months ago

What does this PR do?

The translation string used in the case of comments being rejected when a user is banned is now sent through in the correct order and found in the correct translation file, as well.

These changes will impact:

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

You can ban a user. Then check the moderate card for the comment(s) rejected when they were banned in the admin and see that it says "User was banned." under detailed explanation and not "common-userBanned".

Where any tests migrated to React Testing Library?

How do we deploy this PR?

netlify[bot] commented 9 months ago

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
Latest commit 36173ea95097ff8d445ca04b30e2c0ae3dcb6c85
Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/656f2e9d01ffc10008d55eb6
kabeaty commented 9 months ago

Closing this PR to handle here https://github.com/coralproject/talk/pull/4455