Upgrade to Node 18 (Testing GHA CI pipelines) - Githubissues

coralproject / talk

A better commenting experience from Vox Media

https://coralproject.net

Other

1.89k stars 355 forks source link

Upgrade to Node 18 (Testing GHA CI pipelines) #4451

Closed nick-funk closed 8 months ago

nick-funk commented 9 months ago

What does this PR do?

Re-enables the reverted commit with the Node 18 changes

These changes will impact:

[ ] commenters
[ ] moderators
[ ] admins
[x] developers

What changes to the GraphQL/Database Schema does this PR introduce?

None

Does this PR introduce any new environment variables or feature flags?

No

If any indexes were added, were they added to `INDEXES.md`?

N/A

How do I test this PR?

Pull down branch
Perform a production build using node 18.16.0 and npm 8.0.0
See that the build completes
- Feel free to test Coral functionality too
See that GHA build for this branch has also completed

Were any tests migrated to React Testing Library?

No

How do we deploy this PR?

Merge into develop and target for another release
- May want to release this on its own as its own release as it is upgrading all of node from v14 to v18

netlify[bot] commented 9 months ago

Deploy Preview for gallant-galileo-14878c canceled.

Name	Link
Latest commit	096e6016313b12077c31a79cf495ef01ff981d4b
Latest deploy log	https://app.netlify.com/sites/gallant-galileo-14878c/deploys/65946ebc216fa90008b55f33