coralproject / talk

A better commenting experience from Vox Media
https://coralproject.net
Other
1.89k stars 354 forks source link

[CORL-2510]: Upgrade eslint to v8 #4452

Closed kabeaty closed 9 months ago

kabeaty commented 11 months ago

What does this PR do?

Upgrades eslint to v8. Also upgrades related packages. This also includes removing linting from watch and just letting linting be run separately and as a hook when committing files.

For linting issues that came up, either types were added in or eslint was disabled for the next line.

These changes will impact:

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

Run npm-i.sh to update packages. Then you can click around and see that everything works as expected, that Coral starts up as expected with no errors, etc.

Were any tests migrated to React Testing Library?

How do we deploy this PR?

netlify[bot] commented 11 months ago

Deploy Preview for gallant-galileo-14878c ready!

Name Link
Latest commit bcc717b8b2c6fdd1184a97a0d7c97a39dfb7b6e1
Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/65a689e0358d5c000868cea3
Deploy Preview https://deploy-preview-4452--gallant-galileo-14878c.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.