coralproject / talk

A better commenting experience from Vox Media
https://coralproject.net
Other
1.89k stars 355 forks source link

[CORL-3029]: update to always show notifications #4494

Closed kabeaty closed 7 months ago

kabeaty commented 8 months ago

What does this PR do?

These changes update to always show notifications, whether DSA is enabled or not.

These changes will impact:

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

You can test this by making sure that DSA is turned off. Log in as a commenter and see that notifications tab is visible. See that you either have a message about not yet having any notifications or there are notifications.

Turn DSA back on and see notifications are still showing. See that if there is a DSA method of redress, this only shows at the top of notifications if DSA is enabled.

Were any tests migrated to React Testing Library?

How do we deploy this PR?