coralproject / talk

A better commenting experience from Vox Media
https://coralproject.net
Other
1.89k stars 355 forks source link

[CORL-3030]: New notification types #4498

Closed kabeaty closed 7 months ago

kabeaty commented 8 months ago

What does this PR do?

These changes add new notification types to notifications, including replies, staff replies, and comment approvals. It also adds in checks, such as that a user isn't replying to themselves and the reply isn't coming from an ignored user (in those cases, no notification is needed).

Set as draft pending updated copy/design around how the reply/staff reply/approve/feature notifications should look.

These changes will impact:

What changes to the GraphQL/Database Schema does this PR introduce?

Adds a REPLY_STAFF notification type. Adds commentReply to notifications so that we can use it in reply notifications.

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

You can test these changes by replying to users as a regular commenter and as a staff commenter. Also approve/feature stories (should see the notifications appear, but what will be shown for the comments is still pending).

Were any tests migrated to React Testing Library?

How do we deploy this PR?