coralproject / talk

A better commenting experience from Vox Media
https://coralproject.net
Other
1.89k stars 355 forks source link

[CORL-3042]: Fix feature/unfeature counts bug #4502

Closed kabeaty closed 7 months ago

kabeaty commented 7 months ago

What does this PR do?

These changes address a bug where if a comment was featured or unfeatured multiple times by different mods, then the count would be updated. This makes it so that if a comment is already featured and someone tries to feature it again, it doesn't update counts or otherwise re-feature. If a comment is already unfeatured and someone tries to unfeature it again, it doesn't update counts or otherwise re-unfeature.

These changes will impact:

What changes to the GraphQL/Database Schema does this PR introduce?

Does this PR introduce any new environment variables or feature flags?

If any indexes were added, were they added to INDEXES.md?

How do I test this PR?

See that if you have two windows open with different logged-in mods, and each mod features the same comment, the count will increment by 1 in both cases and it will say "featured". On refresh, the count will still be the same and the comment will still be featured.

See that if you have two windows open with different logged-in mods, and each mod unfeatures the same comment, the count will decrement by 1 in both cases and it will say "unfeatured". On refresh, the count will still be the same and the comment will be unfeatured.

Were any tests migrated to React Testing Library?

How do we deploy this PR?

netlify[bot] commented 7 months ago

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
Latest commit eb9a2c42d2d961ca48cb1847bc0680d8dec96297
Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/65b01901f29c660008ec8daf