Create a notifications tray that is always available - Githubissues

coralproject / talk

A better commenting experience from Vox Media

https://coralproject.net

Other

1.89k stars 355 forks source link

Create a notifications tray that is always available #4504

Closed nick-funk closed 7 months ago

nick-funk commented 7 months ago

What does this PR do?

Adds a live notifications tray that is always available.

when in desktop mode, it floats as an icon in the top right
when in mobile mode, it resides in the Next unread tray

These changes will impact:

[X] commenters
[ ] moderators
[ ] admins
[ ] developers

What changes to the GraphQL/Database Schema does this PR introduce?

None.

Does this PR introduce any new environment variables or feature flags?

None

If any indexes were added, were they added to `INDEXES.md`?

N/A

How do I test this PR?

post a comment
have another account reply to it
see the live button icon update with a new count
click on the button
see the notification list appear
scroll through it and load more (if you have enough notifications)
click on the button to close the list

Were any tests migrated to React Testing Library?

None

How do we deploy this PR?

Merge into epic branch and release that.

netlify[bot] commented 7 months ago

Deploy Preview for gallant-galileo-14878c canceled.

Name	Link
Latest commit	8e29a6e11dfa5902173fb585a4c18dc8beafac88
Latest deploy log	https://app.netlify.com/sites/gallant-galileo-14878c/deploys/65b1a93c7e56b900085d4ab9