coralproject / talk

A better commenting experience from Vox Media
https://coralproject.net
Other
1.89k stars 355 forks source link

Support for Hostnames without TLD in "Site permitted domains" #4505

Closed krestaino closed 7 months ago

krestaino commented 7 months ago

Issue: Coral does not accept non-TLD hostnames (e.g., http://laptop:8500) in "Site permitted domains" under Organization > Site Details. While TLD domains (e.g., https://example.com and http://laptop.local:8500) and localhost (http://localhost:8500) are accepted, hostnames without a TLD yield an "Invalid URL" error. I use Tailscale MagicDNS, where I typically only use hostnames without TLDs.

Request: Allow hostnames without a TLD (http://laptop:8500), similar to the allowance for localhost currently.

Expected behavior: http://laptop:8500 should be a valid URL.

Actual behavior: Error: Invalid URL

image

Versions:

nick-funk commented 7 months ago

We don't support the convenience URL's that Tailscale creates because they are non-standard W3C domains.

However, there should be fallback static IP mappings for these convenience URL's that Tailscale creates for you. You could try using that instead.

krestaino commented 7 months ago

Sounds good, I didn't realize they were non-standard W3C domains, so I understand not wanting to support them here. I appreciate the clarity!