coralproject / talk

A better commenting experience from Vox Media
https://coralproject.net
Other
1.89k stars 355 forks source link

[CORL-3060]: In-page notifications configuration #4513

Closed kabeaty closed 7 months ago

kabeaty commented 7 months ago

What does this PR do?

These changes add in-page notifications configuration (enabled or not) to admin general configuration. This is used to determine whether users see preferences for in-page notifications in their Stream profile preferences.

These changes will impact:

What changes to the GraphQL/Database Schema does this PR introduce?

This adds inPageNotifications to settings.

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

You can go into admin configuration -> general and enable/disable in-page notifications. See that it updates as expected. See that when it's enabled, a user sees the option to adjust their in-page notification preferences.

Were any tests migrated to React Testing Library?

How do we deploy this PR?