search

coralproject / talk

A better commenting experience from Vox Media
https://coralproject.net
Other
1.89k stars 355 forks source link

[CORL-3049]: add x.com to media links #4521

Closed kabeaty closed 7 months ago

kabeaty commented 7 months ago

What does this PR do?

Adds x.com to media links that are supported as media embeds when included in a comment.

These changes will impact:

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

You can test these changes by grabbing an X post url using the share button. This will be an x.com url. Paste it into the comment box. See that you are asked if you would like to add the post to the end of your comment.

Also confirm that twitter.com urls are still supported and work as expected, too.

Were any tests migrated to React Testing Library?

How do we deploy this PR?

netlify[bot] commented 7 months ago

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
Latest commit 53f5baff9f8ecf003f1ad319ea95490292cc5b9f
Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/65bd0c48933eaf0007e6c171