coralproject / talk

A better commenting experience from Vox Media
https://coralproject.net
Other
1.89k stars 355 forks source link

[CORL-3070]: filter out rejected and deleted comments from notifications #4526

Closed kabeaty closed 7 months ago

kabeaty commented 7 months ago

What does this PR do?

Filters out any comment reply notifications with comment replies that are rejected or deleted so that these will not show in the notification view.

These changes will impact:

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

You can reply to comments and then reject the replies. Go to the original comment author and see that the reply doesn't show in their notification tab. Approve the reply comment. Now a notification should show in their notifications tab for it.

Reply to a comment then delete the author who replied (which will also delete their comment). See that this reply notification doesn't appear in the original commenter's notification tab.

Were any tests migrated to React Testing Library?

How do we deploy this PR?