search

coralproject / talk

A better commenting experience from Vox Media
https://coralproject.net
Other
1.89k stars 355 forks source link

[CORL-3076]: Only check protected email domains if banning, not for always premod #4531

Closed kabeaty closed 7 months ago

kabeaty commented 7 months ago

What does this PR do?

These changes make it so that protected email domains can be set to always premod, but they still cannot be set for ban new commenter accounts.

These changes will impact:

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

Attempt to set a protected email domain to always premod in Configure > Moderation > Users. See that it works. Attempt to set it to ban new users. See that it still throws an error.

Were any tests migrated to React Testing Library?

How do we deploy this PR?

netlify[bot] commented 7 months ago

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
Latest commit a82bc6d576b35bcfbcd8073696925a01ae8d41a1
Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/65c648d25f60b600085415c0