These changes make it so that when in-page notifications is enabled, e-mail notifications are disabled. There is also a note about this added to the admin configuration.
These changes will impact:
[x] commenters
[ ] moderators
[x] admins
[ ] developers
What changes to the GraphQL/Database Schema does this PR introduce?
none
Does this PR introduce any new environment variables or feature flags?
no
If any indexes were added, were they added to INDEXES.md?
n/a
How do I test this PR?
You can enable in-page notifications. See that e-mail notifications and their settings are no longer shown. Also see that if you reply to a user (who has e-mail settings for replies enabled) while in-page notifications is enabled, that e-mail notification won't get sent out.
If you disable in-page notifications again, they can then change their e-mail settings and e-mail notifications are sent out again on reply, etc. In-page notification settings are no longer shown in this case, and neither are in-page notifications.
What does this PR do?
These changes make it so that when in-page notifications is enabled, e-mail notifications are disabled. There is also a note about this added to the admin configuration.
These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
none
Does this PR introduce any new environment variables or feature flags?
no
If any indexes were added, were they added to
INDEXES.md?n/a
How do I test this PR?
You can enable in-page notifications. See that e-mail notifications and their settings are no longer shown. Also see that if you reply to a user (who has e-mail settings for replies enabled) while in-page notifications is enabled, that e-mail notification won't get sent out.
If you disable in-page notifications again, they can then change their e-mail settings and e-mail notifications are sent out again on reply, etc. In-page notification settings are no longer shown in this case, and neither are in-page notifications.
Were any tests migrated to React Testing Library?
How do we deploy this PR?