coralproject / talk

A better commenting experience from Vox Media
https://coralproject.net
Other
1.89k stars 355 forks source link

[CORL-3107]: adjust preferences in-page notification settings #4556

Closed kabeaty closed 6 months ago

kabeaty commented 6 months ago

What does this PR do?

These changes update a commenter's in-page notification settings so that they can select to receive replies from everyone or from a staff member. It also updates copy to Badges on/Badges off and Alert me when. It updates the schema for the onReplies setting and updates where this is used.

These changes will impact:

What changes to the GraphQL/Database Schema does this PR introduce?

Updates inPageNotifications.onReplies settings for users.

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

You can test this PR by going into a user's Preferences --> In-page Notifications. See the updated copy. Change settings for when a comment receives a reply and whether it's from everyone or a staff member. See everything saves and is enabled/disabled as expected.

Were any tests migrated to React Testing Library?

How do we deploy this PR?