[CORL-3109] Set screen reader accessible titles for notifications buttons/tabs - Githubissues

coralproject / talk

A better commenting experience from Vox Media

https://coralproject.net

Other

1.88k stars 355 forks source link

[CORL-3109] Set screen reader accessible titles for notifications buttons/tabs #4558

Closed nick-funk closed 6 months ago

nick-funk commented 6 months ago

What does this PR do?

Adds a localized title to the notifications tabs and buttons.

These changes will impact:

[X] commenters
[ ] moderators
[ ] admins
[ ] developers

What changes to the GraphQL/Database Schema does this PR introduce?

None

Does this PR introduce any new environment variables or feature flags?

No

If any indexes were added, were they added to `INDEXES.md`?

N/A

How do I test this PR?

load up the stream in various modes (3 buttons/tabs total)
check that the title property is set on the button action for all tabs/buttons that represent notifications

Were any tests migrated to React Testing Library?

No

How do we deploy this PR?

Merge into epic branch.

netlify[bot] commented 6 months ago

Deploy Preview for gallant-galileo-14878c canceled.

Name	Link
Latest commit	910da40c13a57224c803338ca7c81298cf94bc40
Latest deploy log	https://app.netlify.com/sites/gallant-galileo-14878c/deploys/65d8c843406e8d0008ff721c