update git hooks to use pnpm - Githubissues

coralproject / talk

A better commenting experience from Vox Media

https://coralproject.net

Other

1.88k stars 355 forks source link

update git hooks to use pnpm #4577

Closed nick-funk closed 5 months ago

nick-funk commented 5 months ago

What does this PR do?

Update the git hooks to use pnpm

These changes will impact:

[ ] commenters
[ ] moderators
[ ] admins
[X] developers

What changes to the GraphQL/Database Schema does this PR introduce?

None

Does this PR introduce any new environment variables or feature flags?

No

If any indexes were added, were they added to `INDEXES.md`?

N/A

How do I test this PR?

run sh initialize.sh

make a test branch

git branch precommit-check
git checkout precommit-check

modify the readme or other trivial file
save the file

try and commit, see that it works

git commit -m "don't care, gonna throw away"

let the pre-commit operations happen
see that it commits properly since the git hooks now have access to pnpm

switch back to develop and delete our test branch

git checkout develop
git branch -D precommit-check

Were any tests migrated to React Testing Library?

No

How do we deploy this PR?

Merge into develop.

netlify[bot] commented 5 months ago

Deploy Preview for gallant-galileo-14878c canceled.

Name	Link
Latest commit	b4e9193245065f057d19113af596fb91b1e0697b
Latest deploy log	https://app.netlify.com/sites/gallant-galileo-14878c/deploys/65f48d7dce4d1c0008229dcf