search

coralproject / talk

A better commenting experience from Vox Media
https://coralproject.net
Other
1.88k stars 355 forks source link

[CORL-3162]: remove extra Event from end of viewNotificationsFeed event being emitted #4602

Closed kabeaty closed 3 months ago

kabeaty commented 3 months ago

What does this PR do?

These changes remove the extra Event from the end of viewNotificationsFeed event being sent through.

These changes will impact:

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

You can add a console.log inside of useViewerEvent to get the viewerEvent name in client/src/core/client/framework/lib/events.ts. Then click on the notifications tab. See that the event name viewNotificationsFeed without an extra Event on the end is being emitted.

Were any tests migrated to React Testing Library?

How do we deploy this PR?

netlify[bot] commented 3 months ago

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
Latest commit 60e7723a4e9b8668375e329b3b0240a9a5104198
Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/6631049d6c652300080e856f