[CORL-3172] optimized redis query for counts v2 endpoint - Githubissues

coralproject / talk

A better commenting experience from Vox Media

https://coralproject.net

Other

1.89k stars 355 forks source link

[CORL-3172] optimized redis query for counts v2 endpoint #4660

Closed nick-funk closed 6 days ago

nick-funk commented 6 days ago

What does this PR do?

Replaces the multiple async mget promises with a singular redis mget with multiple key returns.
Replaces the multiple async await with an optimized for loop

These changes will impact:

[ ] commenters
[ ] moderators
[ ] admins
[X] developers

What changes to the GraphQL/Database Schema does this PR introduce?

None

Does this PR introduce any new environment variables or feature flags?

No

If any indexes were added, were they added to `INDEXES.md`?

N/A

How do I test this PR?

Start up Coral
Query the counts v2 endpoint with some storyID's
See that it only makes one call to Redis to retrieve the storyID's

Were any tests migrated to React Testing Library?

No

How do we deploy this PR?

Merge into https://github.com/coralproject/talk/pull/4635

netlify[bot] commented 6 days ago

Deploy Preview for gallant-galileo-14878c canceled.

Name	Link
Latest commit	19933201b688be4ed44bb4b1c246f4a2cb4281f4
Latest deploy log	https://app.netlify.com/sites/gallant-galileo-14878c/deploys/66e08692efcd710008bc2b51