coralproject / talk

A better commenting experience from Vox Media
https://coralproject.net
Other
1.89k stars 355 forks source link

Assistive technologies read landmark label twice #4664

Open michalrusina opened 1 week ago

michalrusina commented 1 week ago

Expected behavior:

When using assistive technologies (screenreaders), all tabbed controls read the word "Tabs" twice. Once because of aria-role="tabs" and second time because there is an span element containing text "Tabs".

Actual behavior:

"Tabs" should be read only once, only use aria-role="tabs" where appropriate.

Related Issues:

This antipattern occurs on all tabbed controls and possibly also on other components.

Versions:

losowsky commented 4 days ago

Thanks - we'll add this to our backlog