search

corazawaf / coraza-benchmark

Coraza Benchmark
Apache License 2.0
1 stars 1 forks source link

Repository maintenance #4

Open jptosso opened 4 days ago

jptosso commented 4 days ago

Ping @s3rj1k @fzipi @jcchavezs @M4tteoP

s3rj1k commented 4 days ago

We had a quick talk regarding CI before with @fzipi. I can take this, but needs a bit more discussion on what exactly we want to check there.

jptosso commented 4 days ago

@s3rj1k it's up for discussion, but I think we should cover tests and run the benchmark making sure that all bechmarks are run. Also, I think we should deprecate v2 benchmarks, as it is not supported anymore and the comparison is irrelevant

s3rj1k commented 4 days ago

deprecate v2 benchmarks

we can add that it's not supported but I would like to keep them as long as possible for reference, this reference has real value for project support because of huge performance increase that can be verified locally

fzipi commented 3 days ago

Found this one that might help: https://github.com/marketplace/actions/continuous-benchmark

s3rj1k commented 3 days ago

We actually don't have go benchmarks there, documentation is wrong about that, we run go application that computes time between stages and produces CSV.

I've done quick docker magic to showcase how it works, just in case we want a demo:

git clone -b docker https://github.com/s3rj1k/coraza-benchmark.git 
cd coraza-benchmark
docker run --rm -v $(pwd)/tests:/opt/coraza-benchmark/tests -v $(pwd)/waf.rules:/opt/coraza-benchmark/waf.rules docker.io/s3rj1k/coraza-benchmark -rules=/opt/coraza-benchmark/waf.rules