search

corazawaf / coraza-proxy-wasm

proxy-wasm filter based on Coraza WAF
Apache License 2.0
115 stars 24 forks source link

Upgrade BDWGC + get rid of build hack for signals #250

Closed plajjan closed 11 months ago

plajjan commented 11 months ago

Just FYI, I opened an issue and @ivmai, the maintainer of the BDW GC fixed so that signals are now conditionally included. Thus it should be possible to remove the build hack you have in https://github.com/anuraaga/coraza-proxy-wasm/blob/90a30fc2c3b338f3fcd7e62edee58921b40f60ee/buildtools/bdwgc/Dockerfile#L12 if you upgrade the GC!

M4tteoP commented 11 months ago

Thanks for pointing it out! The GC is now a dependency of coraza-proxy-wasm and is under https://github.com/wasilibs/nottinygc, but the build hack is here: https://github.com/wasilibs/nottinygc/blob/71b98371a0f408aed22934e02aa029077de2bf02/buildtools/bdwgc/Dockerfile#L16C49-L16C49. So it might totally worth it to address it at the next GC upgrade :)

jcchavezs commented 11 months ago

Cc @anuraaga

anuraaga commented 11 months ago

Thanks @plajjan! That's great news - I incorporated the update to nottinygc.

https://github.com/wasilibs/nottinygc/pull/45